add extra libs for curl (psl, krb5, unistring, idn2)#968
Conversation
This reverts commit a1b8d20.
|
okay, musl doesn't have python? other one just needs LD_LIBRARY_PATH. |
|
I remember that the reason I didn't add these dependencies to curl in the beginning was because it had a library dependency on Python. Dependent on a language with various system-level dependency issues can be quite a headache. |
|
Yeah I think I'll remove psl. Looks like python is no longer default in Ubuntu either. |
| $this->source_dir .= '/src'; | ||
| shell()->cd($this->source_dir)->exec('autoreconf -if'); |
There was a problem hiding this comment.
If there is no need to modify the root directory, it is best to pass the subpath directly instead of modifying it.
There was a problem hiding this comment.
How do we pass a subpath directly? I tried searching for it, but couldn't find it.
There was a problem hiding this comment.
I mean shell()->cd("{$this->source_dir}/src")->exec() instead of modifying it.
There was a problem hiding this comment.
Not working for UnixAutoconfExecutor, that's why I changed it.
There was a problem hiding this comment.
Ah that makes sense. But I think it would be more appropriate to add an arg for executor. I would make changes in 3.0 rather than this PR. I will test later to see if it affects other functions, or we can restore it at the end.
What does this PR do?
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.