Skip to content

feat(quality): [Draft] add ballooning diagram feature #663

Open
neilk17 wants to merge 4 commits intomainfrom
feature/ballooning-view
Open

feat(quality): [Draft] add ballooning diagram feature #663
neilk17 wants to merge 4 commits intomainfrom
feature/ballooning-view

Conversation

@neilk17
Copy link
Copy Markdown
Collaborator

@neilk17 neilk17 commented Apr 11, 2026

PDF-based inspection drawing tool in the Quality module. Users can upload
a drawing, drag to highlight features with numbered balloon annotations,
fill in a feature table (nominal, tolerances, characteristic type), and save.
Reuses qualityDocument table with tags: ["ballooning"] and content JSON.

What does this PR do?

  • Fixes #XXXX (GitHub issue number)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

  PDF-based inspection drawing tool in the Quality module. Users can upload
  a drawing, drag to highlight features with numbered balloon annotations,
  fill in a feature table (nominal, tolerances, characteristic type), and save.
  Reuses qualityDocument table with tags: ["ballooning"] and content JSON.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
academy Ready Ready Preview, Comment Apr 19, 2026 6:02am
carbon Ready Ready Preview, Comment Apr 19, 2026 6:02am
mes Ready Ready Preview, Comment Apr 19, 2026 6:02am

Request Review

Global side effect doesn't belong in a component. Moves to
  entry.client.tsx so it runs once on boot. Switches from a
  manually-copied public/ file to Vite's ?url import so the
  worker version stays in sync with pdfjs-dist automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant