Skip to content

Basic end-to-end ballooning implementation #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
codeit0ut wants to merge 2 commits into
base: feature/ballooning-view
Choose a base branch
from
Draft

Basic end-to-end ballooning implementation #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d5220
Basic end-to-end ballooning implementation
codeit0ut Apr 21, 2026
e116e5e
Enhanced the structure of code & added some features
codeit0ut Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/erp/app/components/Layout/Topbar/Breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ const Breadcrumbs = () => {
return {
breadcrumb: translateBreadcrumb(
typeof result.data.handle.breadcrumb === "function"
? result.data.handle.breadcrumb(m.params)
? result.data.handle.breadcrumb(
m.params,
(m as { data?: unknown }).data
)
: result.data.handle.breadcrumb
),
to: result.data.handle?.to ?? m.pathname
Expand Down
78 changes: 76 additions & 2 deletions apps/erp/app/modules/quality/quality.models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export const balloonCharacteristicType = [
"Reference"
] as const;

export const ballooningDiagramValidator = z.object({
export const balloonDocumentValidator = z.object({
id: zfd.text(z.string().optional()),
name: z.string().min(1, { message: "Name is required" }),
drawingNumber: zfd.text(z.string().optional()),
Expand All @@ -106,7 +106,7 @@ export const ballooningDiagramValidator = z.object({

export const balloonFeatureValidator = z.object({
id: zfd.text(z.string().optional()),
ballooningDiagramId: z.string().min(1, { message: "Diagram is required" }),
balloonDocumentId: z.string().min(1, { message: "Diagram is required" }),
balloonNumber: zfd.numeric(z.number().min(1)),
description: z.string().min(1, { message: "Description is required" }),
nominalValue: zfd.numeric(z.number().optional()),
Expand All @@ -117,6 +117,80 @@ export const balloonFeatureValidator = z.object({
sortOrder: zfd.numeric(z.number().optional())
});

export const balloonAnchorCreateItemValidator = z.object({
pageNumber: z.number(),
xCoordinate: z.number(),
yCoordinate: z.number(),
width: z.number(),
height: z.number()
});

export const balloonAnchorUpdateItemValidator = z.object({
id: z.string().min(1),
pageNumber: z.number().optional(),
xCoordinate: z.number().optional(),
yCoordinate: z.number().optional(),
width: z.number().optional(),
height: z.number().optional()
});

export const balloonAnchorDeleteValidator = z.object({
ids: z.array(z.string().min(1))
});

export const balloonCreateFromPayloadItemValidator = z.object({
tempSelectorId: z.string().min(1),
label: z.string().min(1),
xCoordinate: z.number(),
yCoordinate: z.number(),
anchorX: z.number(),
anchorY: z.number(),
data: z.record(z.unknown()),
description: z.string().nullable().optional()
});

export const balloonUpdateItemValidator = z.object({
id: z.string().min(1),
label: z.string().optional(),
xCoordinate: z.number().optional(),
yCoordinate: z.number().optional(),
anchorX: z.number().optional(),
anchorY: z.number().optional(),
data: z.record(z.unknown()).optional(),
description: z.string().nullable().optional()
});

export const balloonDeleteValidator = z.object({
ids: z.array(z.string().min(1))
});

export const balloonAnnotationCreateItemValidator = z.object({
pageNumber: z.number().int().min(1),
xCoordinate: z.number(),
yCoordinate: z.number(),
text: z.string().min(1),
width: z.number().optional(),
height: z.number().optional(),
rotation: z.number().optional(),
style: z.record(z.unknown()).optional()
});

export const balloonAnnotationUpdateItemValidator = z.object({
id: z.string().min(1),
pageNumber: z.number().int().min(1).optional(),
xCoordinate: z.number().optional(),
yCoordinate: z.number().optional(),
text: z.string().min(1).optional(),
width: z.number().nullable().optional(),
height: z.number().nullable().optional(),
rotation: z.number().optional(),
style: z.record(z.unknown()).nullable().optional()
});

export const balloonAnnotationDeleteValidator = z.object({
ids: z.array(z.string().min(1))
});

export const gaugeValidator = z.object({
id: zfd.text(z.string().optional()),
gaugeId: zfd.text(z.string().optional()),
Expand Down
Loading