Support customize subscribe.options && compatible with null value for type int#514
Conversation
cyrushine
commented
Oct 26, 2020
- according to https://wamp-proto.org/_static/gen/wamp_latest.html#subscribe-0, message SUBSCRIBE.Options is a dict that allows to provide additional subscription request details in a extensible way
- make java type int/long compatible with null value of wamp type int
|
thanks for contributing! rgd custom (implementation defined, rather than official protocol defined) attributes: the library should only accept attribute names |
|
👌 |
|
@om26er what do you think rgd the PR? good to merge? in general, the AB libraries should allow users to use custom attributes in "options". such custom options must have attribute names starting with "x_". other attribute names must be from the list of officially supported (eg "exclude_authroles" or similar). do we want to check/enforce that in the ABPy client side library? eg Crossbar.io will kill a session that uses non-standard attribute names that do not start with "x_" - but we certainly could add such checks later in a subsequent change (as this PR doesn't protect from using illegal names ..) |
|
Yep, looks good to me. We can add the protection for illegal names later. |