Push function-kcl to GHCR#261
Conversation
Signed-off-by: Nic Cope <nicc@rk0n.org>
| - name: Push Latest Package to Upbound | ||
| if: env.XPKG_ACCESS_ID != '' | ||
| run: "./crossplane --verbose xpkg push --package-files $(echo *.xpkg|tr ' ' ,) ${{ env.XPKG }}:latest" |
There was a problem hiding this comment.
Note that I've intentionally omitted pushing a :latest tag to GHCR.
Crossplane packages shouldn't use the :latest tag. Package tags should always be semantic versions. This is required for the package manager to support dependency resolution. We need to update https://github.com/crossplane/crossplane/blob/main/contributing/specifications/xpkg.md to state this.
|
Once this is merged we'll need to re-run CI to push |
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
LGTM, looks like the same approach taken as crossplane-contrib/function-patch-and-transform#171 🤓
These folks have maintainer perms on this repo in the GitHub settings. Signed-off-by: Nic Cope <nicc@rk0n.org>
| * Peefy ([peefy](https://github.com/peefy)) | ||
| * Zong Zhe ([zong-zhe](https://github.com/zong-zhe)) |
|
Updated the PR to add an |
3 participants
Description of your changes
See #252 (comment) for context.
We'd like to add function-kcl as an option in a new getting started with composition guide on https://docs.crossplane.io. We're currently unable to do that, because it's only pushed to
xpkg.upbound.io. We now need packages to be pushed toxpkg.crossplane.ioin order for them to appear in the documentation.I have:
Added or updated unit tests for my change.