various encloud related backports for SOC7#1634
Merged
Merged
Conversation
houndci-bot
reviewed
Apr 13, 2018
| cpu_mode = compute_flags["cpu_mode"] | ||
| end | ||
|
|
||
| if File.exists?("/sys/devices/virtual/misc/hw_random/rng_current") && |
There was a problem hiding this comment.
Lint/DeprecatedClassMethods: File.exists? is deprecated in favor of File.exist?.
houndci-bot
reviewed
Apr 13, 2018
| end | ||
|
|
||
| def downgrade(ta, td, a, d) | ||
| unless ta["kvm"].key? "disk_cachemodes" |
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)
| return a, d | ||
| end | ||
|
|
||
| def downgrade(ta, td, a, d) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| @@ -0,0 +1,13 @@ | |||
| def upgrade(ta, td, a, d) | |||
| unless a["kvm"].key? "disk_cachemodes" | |||
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)
| @@ -0,0 +1,13 @@ | |||
| def upgrade(ta, td, a, d) | |||
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
This allows the administrator to select flavors or images to pass through entropy devices to the guest to give them a chance of securely generating crypto nounces. Note the default seems to be off, it needs to be enabled in the nova flavor via an "hw_rng:allowed=True" extra specs (cherry picked from commit 31e29a5)
Installation order isn't properly defined, so we don't want apache2 to restart in the middle of while we're still updating . Chef will trigger a restart when we're ready (cherry picked from commit 7c4e111)
This seems to be the upstream default, and more than one thread seems to act really weirdly (slow) when using the LDAP backend (causing random multi second hangs) (cherry picked from commit 5ff2560)
This enables the creation of trunk ports in neutron e.g. to be able to use tagged vlans inside VM instances. (cherry picked from commit 0d63f7e)
When all schedulers are picking the "best" host, in a 3 node HA case they will all pick the same host, which is suboptimal. Try to scale out a bit and increase retries in case of conflicts. Even worse, a node that had still capacity when the scheduling started might be out of memory at the time the VM is launched, causing failed starts of VMs. (cherry picked from commit 89071b4)
Also default to writeback for network, which is improving the performance quite a bit for ceph backed volumes and is safe to enable (and recommended by almost every openstack install guide) (cherry picked from commit d5f5567)
rsalevsky
approved these changes
May 4, 2018
rhafer
approved these changes
May 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.