rabbitmq: Do not check if service is running when it is not supposed to run#1637
Merged
Merged
Conversation
…to run. pre-upgrade attribute is set to true to indicate the case that the upgrade of the node has not been finished yet. In such case, services cannot start on the node (there's a location constraint that prevents that). See disable_pre_upgrade_attribute_for method in models/api/node.rb for more info
jsuchome
force-pushed
the
rabbitmq-during-upgrade
branch
from
24794f3 to
54aad46
Compare
nicolasbock
approved these changes
Apr 23, 2018
rhafer
approved these changes
Apr 24, 2018
Itxaka
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-upgrade attribute is set to true to indicate the case that the upgrade of the node has
not been finished yet. In such case, services cannot start on the node
(there's a location constraint that prevents that).
See disable_pre_upgrade_attribute_for method in models/api/node.rb for more info