aodh: Add config for alarm_history_ttl (bsc#1073703)#1674
Conversation
The alarm_history_ttl config option for aodh was not previously configurable.
| end | ||
|
|
||
| def downgrade(ta, td, a, d) | ||
| unless ta.key? "alarm_history_ttl" |
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)
| return a, d | ||
| end | ||
|
|
||
| def downgrade(ta, td, a, d) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| @@ -0,0 +1,13 @@ | |||
| def upgrade(ta, td, a, d) | |||
| unless a.key? "alarm_history_ttl" | |||
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)
| @@ -0,0 +1,13 @@ | |||
| def upgrade(ta, td, a, d) | |||
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| end | ||
|
|
||
| def downgrade(ta, td, a, d) | ||
| unless ta.key? "alarm_history_ttl" |
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)
| return a, d | ||
| end | ||
|
|
||
| def downgrade(ta, td, a, d) |
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| @@ -0,0 +1,13 @@ | |||
| def upgrade(ta, td, a, d) | |||
| unless a.key? "alarm_history_ttl" | |||
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)
| @@ -0,0 +1,13 @@ | |||
| def upgrade(ta, td, a, d) | |||
There was a problem hiding this comment.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
|
As I cannot update the original PR (#1655) I open this instead. Is the full work from @cinerama70 with some of the concern addressed. |
|
Needs backport to SOC7 ? Looking at the bug report, it appears so. |
|
Backport here: #1689 |
6 participants
The alarm_history_ttl config option for aodh was
not previously configurable.