Skip to content

Add rate limiting for glance api (bsc#1005886)#1677

Merged
JanZerebecki merged 1 commit into
crowbar:masterfrom
JanZerebecki:glane-api-rate-limit
Jun 18, 2018
Merged

Add rate limiting for glance api (bsc#1005886)#1677
JanZerebecki merged 1 commit into
crowbar:masterfrom
JanZerebecki:glane-api-rate-limit

Conversation

@JanZerebecki

@JanZerebecki JanZerebecki commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Disabled by default default. It can be set to avoid filling up image related tables.

Though the tables are only filled by POST requests this limit is for all
request types.

See https://wiki.openstack.org/wiki/OSSN/OSSN-0076 for details.

return a, d
end

def downgrade(ta, td, a, d)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

@@ -0,0 +1,9 @@
def upgrade(ta, td, a, d)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.

@JanZerebecki

Copy link
Copy Markdown
Contributor Author

I haven't checked yet, if 2 is a sane default.

@nicolasbock

Copy link
Copy Markdown
Contributor

@JanZerebecki Why not set the default to 0 as in the referenced PR so that the operator can choose a sensible value? For instance, if the rate applies across all users then it will have to scale somewhat with the number of users.

Disabled by default default. It can be set to avoid filling up image
related tables.

Though the tables are only filled by POST requests this limit is for all
request types.

See https://wiki.openstack.org/wiki/OSSN/OSSN-0076 for details.
@JanZerebecki JanZerebecki force-pushed the glane-api-rate-limit branch from fa2d4fb to c4c1b8e Compare June 7, 2018 11:02
@JanZerebecki

Copy link
Copy Markdown
Contributor Author

Changed default to 0.

@nicolasbock nicolasbock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Itxaka Itxaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

"crowbar-revision": 0,
"crowbar-applied": false,
"schema-revision": 201,
"schema-revision": 202,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now we need to jump to 300 as we had 100 for cloud6 and 200 for cloud8, it makes sense to start with 300 for cloud9?

Sorry for the nitpick, feel free to ignore and merge :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch will be backported to Cloud7 and there is no branch for Cloud8 yet, so lets see if can be merged before the branch is created.

@JanZerebecki JanZerebecki merged commit 31075d5 into crowbar:master Jun 18, 2018
@JanZerebecki JanZerebecki deleted the glane-api-rate-limit branch June 18, 2018 13:14
JanZerebecki added a commit to JanZerebecki/crowbar-openstack that referenced this pull request Jun 18, 2018
Disabled by default default. It can be set to avoid filling up image
related tables.

Though the tables are only filled by POST requests this limit is for all
request types.

See https://wiki.openstack.org/wiki/OSSN/OSSN-0076 for details.

(cherry picked from commit c4c1b8e)
Backport of crowbar#1677
aplanas pushed a commit to aplanas/crowbar-openstack that referenced this pull request Jun 20, 2018
Disabled by default default. It can be set to avoid filling up image
related tables.

Though the tables are only filled by POST requests this limit is for all
request types.

See https://wiki.openstack.org/wiki/OSSN/OSSN-0076 for details.

(cherry picked from commit c4c1b8e)
Backport of crowbar#1677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants