ironic: Use IP also in [swift] section#2107
Merged
Merged
Conversation
Contributor
|
so why can it reach crowbar internal ip addresses but not hostnames? I am confused about that. |
Member
Author
|
@dirkmueller I think the deploy image doesn't have proper resolver setup. I tried the same with upstream coreos deploy image and it also didn't work with hostnames. |
dirkmueller
previously approved these changes
Apr 25, 2019
skazi0
force-pushed
the
ironic-swift-ip-condigdrive
branch
from
b623280 to
7f8a186
Compare
Member
Author
|
testing gating with #2116 |
skazi0
force-pushed
the
ironic-swift-ip-condigdrive
branch
from
36d2ad2 to
7f8a186
Compare
Member
Author
|
testing gating again with #2116 (new version) |
Swift settings in [glance] already use IP for endpoint URL. This is used for deployment images. If config drive is enabled and stored in Swift, this endpoint URL is not used but instead standard keystone adapter is created based on [swift] section of Ironic configuration. Added override makes it possible to use deploy image which can't resolve Crowbar's internal domain names.
skazi0
force-pushed
the
ironic-swift-ip-condigdrive
branch
from
25e0551 to
ddcd19f
Compare
dirkmueller
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift settings in [glance] already use IP for endpoint URL. This
is used for deployment images.
If config drive is enabled and stored in Swift, this endpoint URL
is not used but instead standard keystone adapter is created based
on [swift] section of Ironic configuration. Added override makes
it possible to use deploy image which can't resolve Crowbar's
internal domain names.