database: Raise and align promote/demote timeouts (bsc#1131791)#2114
Merged
Conversation
Looks like 5 minutes is too short in some cases when a new node is joining. I have observed the 5 min timeout in a small cloud of 100 nodes already that has been operated for some time, so we might be better off being conservative.
nicolasbock
approved these changes
Apr 24, 2019
toabctl
reviewed
May 13, 2019
| }, | ||
| "demote": { | ||
| "timeout": "60s" | ||
| "timeout": "600s" |
Contributor
There was a problem hiding this comment.
Why is increasing the demote timeout needed?
toabctl
approved these changes
May 13, 2019
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like 5 minutes is too short in some cases
when a new node is joining. I have observed the 5 min timeout
in a small cloud of 100 nodes already that has been operated
for some time, so we might be better off being conservative.