database: Make wsrep_provider_options configurable (fate#327745)#2127
Merged
toabctl merged 1 commit intoMay 15, 2019
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
vuntz
reviewed
May 14, 2019
| "bootstrap_timeout": 600, | ||
| "wsrep_slave_threads" : 1, | ||
| "gcs_fc_limit_multiplier" : 5, | ||
| "wsrep_provider_options_custom" : [], |
Member
There was a problem hiding this comment.
Wondering out loud: is it easier/less confusing to use a sequence of string, or a single string (where we would require the user to use ;)?
Contributor
Author
There was a problem hiding this comment.
I don't care. I can also switch to a single string instead of a list of strings. What do you prefer?
There was a problem hiding this comment.
So how would that work in batch? Like wsrep_provider_options_custom: [ "gcache.size=2G" ]
Member
There was a problem hiding this comment.
What do you prefer?
No strong feeling on my side. Just raising this in case someone has strong feelings ;-)
Contributor
Author
There was a problem hiding this comment.
@alexdepalex, yes. Or with multiple options like:
"wsrep_provider_options_custom": [
"gcache.size=2G",
"debug=yes"
],
which results in:
root@d52-54-77-77-01-01:~ # grep wsrep_provider_options /etc/my.cnf.d/75-galera.cnf
wsrep_provider_options = "gmcast.listen_addr=tcp://192.168.206.82:4567;gcs.fc_limit = 5;gcs.fc_factor = 0.8";gcache.size=2G;debug=yes
vuntz
previously approved these changes
May 14, 2019
rhafer
suggested changes
May 14, 2019
rhafer
suggested changes
May 14, 2019
rhafer
previously approved these changes
May 14, 2019
jsuchome
previously approved these changes
May 14, 2019
It is sometimes useful to be able to add extra options (like gcache.size, gcs.fc_debug, ...) to the galera wsrep_provider_options configuration variable. This can now be done via the Crowbar RAW view. Also make (the currently hardcoded) "gcs.fc_limit" multiplier configurable. Also make (the currently hardcoded) "gcs.fc_factor" configurable.
rhafer
approved these changes
May 15, 2019
vuntz
approved these changes
May 15, 2019
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is sometimes useful to be able to add extra options (like
gcache.size, gcs.fc_debug, ...) to the galera wsrep_provider_options
configuration variable.
This can now be done via the Crowbar RAW view.