[5.0] neutron: Don't restart l3-ha on .openrc change + timeout extension#2140
Merged
skazi0 merged 3 commits intoMay 31, 2019
Merged
Conversation
l3-ha service doesn't use .openrc so it doesn't need to be restarted when that file is modified. (cherry picked from commit 56e4bed)
This openrc should no longer be needed now that we have the neutron l3-ha-service which consumes its configuration from a yaml file. (cherry picked from commit aa20716)
The agent status is anyway not very quickly updated, and if we retry too quickly we still might not have the underlying problem fixes. Lets be more conservative and check every 30s instead of 10s. (cherry picked from commit 59672c8)
dirkmueller
approved these changes
May 23, 2019
JanZerebecki
approved these changes
May 31, 2019
JanZerebecki
left a comment
JanZerebecki
left a comment
Contributor
There was a problem hiding this comment.
CI failure unrelated. Maybe SUSE-Cloud/automation#3461 will fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
l3-ha service doesn't use .openrc so it doesn't need to be restarted
when that file is modified.
Second commit removes redundant generation of .openrc in neutron cookbook.
Third one increases grace period for l3-ha service from 10x10s to 10x30s. This is needed to improve reliability of CI running in ECP.
port of #2137