[4.0] Make ovs of_inactivity_probe configurable from neutron barclamp#2162
Conversation
nicolasbock
left a comment
nicolasbock
left a comment
There was a problem hiding this comment.
Could you clean up the commit message and remove the "conflicts"?
As far as I understand, SOC 7 is Newton based. Are we backporting the patch you reference to Newton? Upstream it doesn't seem like it is.
| @@ -0,0 +1,15 @@ | |||
| def upgrade(tattr, tdep, attr, dep) | |||
There was a problem hiding this comment.
The migration should be 124.
There was a problem hiding this comment.
Yeah, it's a backport to Newton. Newton is EoL upstream so there's no corresponding upstream patch for that branch; we have it in for Pike and up. I can remove the note about the conflicts.
There was a problem hiding this comment.
You also need to rename the migration file 😄
| "crowbar-revision": 0, | ||
| "crowbar-applied": false, | ||
| "schema-revision": 123, | ||
| "schema-revision": 307, |
There was a problem hiding this comment.
Ok, thanks, I wasn't sure if 124 would conflict with a later patch in soc8 so I left it the same as the version on master, but I can change that.
There was a problem hiding this comment.
No, it shouldn't. We jump to the next hundred with each release, i.e. SOC 8 -> 200, SOC 9 -> 300.
There was a problem hiding this comment.
Cool, thanks for explaining. :)
zzaimeche
force-pushed
the
soc7-inactivity-probe
branch
from
1bc4d8b to
1e6205b
Compare
| @@ -0,0 +1,15 @@ | |||
| def upgrade(tattr, tdep, attr, dep) | |||
There was a problem hiding this comment.
You also need to rename the migration file 😄
This patch allows the user to change the ovs inactivity_probe timeout from the neutron barclamp, in the 'raw' view. Previously, this value was always set to the OVS default, 5. It provides crowbar support for this upstream patch: https://review.opendev.org/#/c/663024/
zzaimeche
force-pushed
the
soc7-inactivity-probe
branch
from
1e6205b to
c0a4d9e
Compare
Itxaka
changed the title
4 participants
This patch allows the user to change
the ovs inactivity_probe timeout from the neutron barclamp, in the 'raw'
view. Previously, this value was always set to the OVS default, 5.
It provides crowbar support for this upstream patch:
https://review.opendev.org/#/c/663024/