isCrownstoneInNormalMode() and isCrownstoneInSetupMode() time out without error

[vliedel]

When calling isCrownstoneInSetupMode() or isCrownstoneInNormalMode() with waitUntilInRequiredMode=True, it will only wait for scanDuration seconds, and then timeout without error. Although the result is set to False, I'd expect an error to be thrown there.

[AlexDM0]

This is a blocking check which returns a boolean. What should we throw an error about?

if (lib.isCrownstoneInSetupMode):
    ... do something

# is better than try catch

I suppose we could rename waitUntilInRequiredMode to waitUntilInRequiredModeOrTimeout to fix this...

[vliedel]

I think the function is either used as:

if isCrownstoneInSetupMode():
    do something
else:
    do something else

or

if isCrownstoneInSetupMode(waitUntilInRequiredMode=True):
    do something
else:
    fail

So a try catch, and maybe a longer default timeout would more suit the latter.

[AlexDM0]

The fail is really dependent on how you use it. We have to account for the Crownstone just not entering setupmode, or our stack not seeing it. We know how long this SHOULD take. The longer timeout would not help. I wouldnt force the catching of the error in this API.

[AlexDM0]

Hmm come to think of it, if your BLE stack is crap, the no-scans-received option would also return false instead of error... I guess we could improve the API to better reflect this case.