Skip to content

optim: skipping more subtrees for pruning mode#9

Merged
yihuang merged 5 commits intocrypto-com:mainfrom
yihuang:skip-more-subtree
Dec 9, 2022
Merged

optim: skipping more subtrees for pruning mode#9
yihuang merged 5 commits intocrypto-com:mainfrom
yihuang:skip-more-subtree

Conversation

@yihuang
Copy link
Copy Markdown

@yihuang yihuang commented Dec 9, 2022

No description provided.

@yihuang yihuang requested a review from mmsqe December 9, 2022 02:25
@yihuang yihuang changed the title optim: skipping more trees for pruning mode optim: skipping more subtrees for pruning mode Dec 9, 2022
Copy link
Copy Markdown

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO predecessor hide less knowledge than isSkipped flag

@yihuang
Copy link
Copy Markdown
Author

yihuang commented Dec 9, 2022

LGTM. IMO predecessor hide less knowledge than isSkipped flag

do you mean our algorithm traverse more nodes than that one?

@mmsqe
Copy link
Copy Markdown

mmsqe commented Dec 9, 2022

do you mean our algorithm traverse more nodes than that one

Just mean predecessor is more intuitive, since I confused why only visit rightNode direction when have both right and left node, then I realize cosmos/iavl#646 (comment)

@yihuang yihuang merged commit e3ffe83 into crypto-com:main Dec 9, 2022
@yihuang yihuang deleted the skip-more-subtree branch December 9, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants