Skip to content

fix: use getAllInterfaceFields in type-inference getInterfaceProperty#130

Merged
cs01 merged 1 commit intomainfrom
fix/get-interface-property-all-fields
Mar 8, 2026
Merged

fix: use getAllInterfaceFields in type-inference getInterfaceProperty#130
cs01 merged 1 commit intomainfrom
fix/get-interface-property-all-fields

Conversation

@cs01
Copy link
Copy Markdown
Owner

@cs01 cs01 commented Mar 8, 2026

Summary

  • getInterfaceProperty() in type-inference.ts used iface.fields directly in its fallback path, missing inherited fields from extends chains
  • Added getAllFieldsForInterface() private method that recursively collects fields from parent interfaces
  • The primary path via typeResolverGetInterfaceProperty already handled inheritance correctly; this fixes the fallback path when typeResolver is unavailable

Test plan

  • All 433 tests pass
  • Self-hosting verification passes (Stage 0 + Stage 1)

🤖 Generated with Claude Code

… for inherited field lookup

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cs01 cs01 merged commit 6c93924 into main Mar 8, 2026
10 checks passed
@cs01 cs01 deleted the fix/get-interface-property-all-fields branch March 9, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant