fix: replace nested inline type assertions with named ast types#145
Merged
fix: replace nested inline type assertions with named ast types#145
Conversation
…vm-generator Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as { members: { name, value }[] }) from enum methods inllvm-generator.ts— these are native compiler crash risks per CLAUDE.mdas { statements: { type, value? }[] }) with namedBlockStatement/ReturnStatementtypesascasts where types were already correct (ast.enumsisEnumDeclaration[])Notes
for...ofonthis.ast.enumsbreaks self-hosting (Stage 1 fails with "Method setSourceCode not found") — kept indexed loops. This is a separate native compiler bug worth investigating.Test plan
npm run verify:quickpasses (tests + Stage 0 + Stage 1)🤖 Generated with Claude Code