Skip to content

fix: compile-time errors for silent map/set method dispatch fallthroughs#148

Merged
cs01 merged 1 commit intomainfrom
fix/map-set-silent-fallthrough
Mar 9, 2026
Merged

fix: compile-time errors for silent map/set method dispatch fallthroughs#148
cs01 merged 1 commit intomainfrom
fix/map-set-silent-fallthrough

Conversation

@cs01
Copy link
Copy Markdown
Owner

@cs01 cs01 commented Mar 9, 2026

Summary

  • Non-string Set fields (this.fieldName.add/has/delete()) silently fell through with no IR emitted and no error when thisFieldSetValueType !== "string" — now dispatches to numeric set handlers
  • String Map/Set local variables with missing alloca silently fell through to wrong-type handlers — now emits compile-time error
  • All three paths previously produced broken binaries with no diagnostic

Test plan

  • npm run verify:quick passes (tests + self-hosting Stage 0 + Stage 1)
  • No new test failures

🤖 Generated with Claude Code

@cs01 cs01 merged commit 1fb220a into main Mar 9, 2026
12 checks passed
@cs01 cs01 deleted the fix/map-set-silent-fallthrough branch March 12, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant