Conversation
d25bf90 to
6183a46
Compare
6183a46 to
20c84fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor array codegen into submodules
Break down the monolithic
array.ts(3500+ lines) into focused submodule files underarray/, matching the pattern already used bystring/submodules.What changed
array.ts— reduced from ~3500 lines to a thin facade (~210 lines) that delegates to submodulesarray/search-predicate.ts(new) —find,some,every,includeswith their string-array variantsarray/iteration.ts(new) —filter,forEach,reduce,mapwith their string-array variantsarray/combine.ts(new) —join,slice,concat, spread literals with their string-array variantsarray/context.ts— added sharedloadArrayMetaanddetectArrayTypehelpers, unified onIGeneratorContextarray/literal.ts,array/mutators.ts— minor cleanup to use unifiedIGeneratorContextDesign
IGeneratorContextdirectly (same pattern as string submodules)findIndexandsortkeep predicate/comparator resolution in the facade since they need pre-resolved values before delegatingloadArrayMeta,detectArrayType) live incontext.tsto avoid name collisions across submodule files.claude/rules.mdupdated to document the new submodule structureTest plan