fix boolean class fields and map/filter on class field arrays#474
Merged
Conversation
Contributor
Benchmark Results (Linux x86-64)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i1/doubletype mismatch in GEP calculations.map()/.filter()on class instance arrays stored as class fields now correctly resolve element types in callbacks, so field access in callbacks returns real values instead of garbageChanges
member.ts: fixclassFieldToLlvm()to returndoublefor boolean (matching actual class struct layout)iteration.ts: addresolveObjectArrayElementType()helper that handlesmember_accessexpressions (e.g.this.items) in addition to simple variables, used by filter/forEach/reduce/mapTest plan
class-boolean-field.ts— boolean field access on class instancesclass-field-array-map-filter.ts— filter/map onthis.itemsinside class methodsnpm run verifypasses (all 758 tests + 3-stage self-hosting)🤖 Generated with Claude Code