optimize bounds checks: unsigned compare + noreturn#475
Merged
Conversation
Contributor
Benchmark Results (Linux x86-64)
|
0f5e241 to
ab79e63
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icmp uge(unsigned compare) instead of two signed compares + or, cutting per-check instruction count by 60%noreturnattribute to__cs_bounds_fail, letting LLVM better optimize around the cold error pathlet i = lo) to i64, enabling integer arithmetic in quicksort-style loops — quicksort benchmark drops from 0.35s → 0.14s (2.5x faster, now beats Go)fptosicodegen at init + demotion fixpoint for reassignments ensures correctnessTest plan
🤖 Generated with Claude Code