Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chad build --target linux-x64failing withunknown specifier 'x' target datalayout = "x86_64-unknown-linux-gnu"— the native binary was emitting the target triple as the LLVM data layout stringnative-compiler-lib.tstypedtargetInfoasanyto avoid importingTargetInfofromtarget.ts(which depends on Node'sosmodule). The native compiler couldn't resolve GEP field indices for theany-typed object, sothis.targetInfo.dataLayoutread the wrong struct field (returning the triple instead)TargetInfointerface andLibCtype into a new dependency-freesrc/target-types.ts, allowing the self-hosted path to import proper type info without pulling in Node'sosmodulee-, not be the triple), and added a native binary cross-compile test that would have caught this bug in CITest plan
npm test— 226 tests pass (225 existing + 1 new native binary cross-compile test)npm run verify:quick— self-hosting verification passed (Stage 0 + Stage 1).build/chad ir --target linux-x64now emits correcttarget datalayout = "e-m:e-p270:32:32-..."instead of the triplenode dist/chad-node.js build --target linux-x64) still works