Skip to content

Hide code of conduct link when none is set#71

Merged
sikesbc merged 2 commits into
mainfrom
fix/hide-code-of-conduct-link
Apr 24, 2026
Merged

Hide code of conduct link when none is set#71
sikesbc merged 2 commits into
mainfrom
fix/hide-code-of-conduct-link

Conversation

@sikesbc
Copy link
Copy Markdown

@sikesbc sikesbc commented Apr 16, 2026

What this PR does:

  • Fixes the registration form (new/edit) rendering an empty code of conduct modal and nav link when no code of conduct is set on the organization. Adds the same unless @conference.code_of_conduct.blank? guard that every other callsite already uses.

Related upstream issue: snap-cloud#211

Include screenshots, videos, etc.

  • N/A: one-line view fix, no UI additions.

Who authored this PR?
@sikesbc

How should this PR be tested?

  • Find a conference whose organization has no code of conduct set.
  • Visit the new or edit registration page for that conference.
  • Confirm there is no "Code of Conduct" modal or nav link on the page.
  • Set a code of conduct on the organization and revisit — confirm the modal and link now appear.
  • New specs in spec/controllers/conference_registration_controller_spec.rb cover both cases.

Are there any complications to deploying this?

  • No migrations or data changes, just a guard clause in a view partial.

@sikesbc sikesbc merged commit e580134 into main Apr 24, 2026
13 of 17 checks passed
@sikesbc sikesbc deleted the fix/hide-code-of-conduct-link branch April 24, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant