Tentative accept#74
Merged
Merged
Conversation
…ack' field of event for sending email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pull request implements tentative acceptance, a new event state between New and Unconfirmed. When selecting Tentative Accept, and provided that email sending is enabled, an email gets sent to the event submitter telling them why their event was only tentatively accepted and what they can change to make it completely accepted (using the committee feedback field of the event
Include screenshots, videos, etc.
A new dropdown selection is added to new events:
After selecting Tentatively Accept, an email template is brought up, showing what email is about to be sent.
If no committee feedback is present, then tentateively accepting is impossible
Who authored this PR?
Ethan Stone
How should this PR be tested?
Tests have been added in events_controller_spec.rb
Currently deployed to Heroku, but that is changing for the presentation demo tomorrow
Are there any complications to deploying this?
There is one data migration, in 20260410133000_add_tentative_accepted_to_email_settings.rb
@cycomachead