Headings mixin generates an error

[marcinkrawiec]

The headings mixin seems to be broken (inuit v5.0, fetched yesterday). The following code:

@include headings(1,6) {
    color: #aaa;
}

generates an error:

error scss/screen.scss (Line 40 of scss/inuit.css/generic/_mixins.scss: Invalid CSS after "": expected selector_comma_sequence, was ", h1, h2, h3, h...")

As you can see there is a comma at the beginning instead of the first heading selector.

Probably it should be something like that:

@mixin headings($from: 1, $to: 6){
    @if $from >= 1 and $to <= 6{
        $heading-selector: (unquote("h#{$from}"));
        @for $i from ($from+1) through $to {
            $heading-selector: $heading-selector, unquote("h#{$i}")
        }
        #{$heading-selector}{
            @content
        }
    }
}

[csswizardry]

This has been patched in v5.0.1; feel free to copy/paste the changes ahead of time:

inuit.css/generic/_mixins.scss

Lines 22 to 46 in 0c1bcc2

	/**
	* Style any number of headings in one fell swoop, e.g.:
	*
	.foo{
	@include headings(1, 3){
	color:#BADA55;
	}
	}
	*
	* With thanks to @lar_zzz, @paranoida, @rowanmanning and ultimately
	* @thierrylemoulec for refining and improving my initial mixin.
	*/
	@mixin headings($from: 1, $to: 6){
	%base-heading {
	@content
	}
	@if $from >= 1 and $to <= 6{
	@for $i from $from through $to{
	h#{$i}{
	@extend %base-heading;
	}
	}
	}
	}