Avoid to simlulate the existance of std.#1
Open
0ndorio wants to merge 3 commits into
Open
Conversation
The main reason to re-export core from here was to simulate the standard library to ensure that the generated bindings are able to find all required data types at their expected locations. This is longer necessary as the bindings are now generated with an additional flag to ensure that they directly use core instead of std.
Bindings are now generated in a way that allows to pass a custom module name which is expected to contain all required ctypes. As a result we are no longe required to simulate the existance of std.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of
esp32-sysis required to simulate the existance ofstd::os::rawas the bindings are generated without the--cyptes-prefixflag. Without this flag any libc related types are automatically imported via::std::os::raw.This is also the reason why the
esp32-syscrate couldn't be compiled with theedition = "2018"flag.(see ctron/rust-esp-container#2 for the required change inside the template repository)