Backup/before rollback#409
Merged
Merged
Conversation
MrPeterss
approved these changes
Oct 10, 2025
Contributor
MrPeterss
left a comment
MrPeterss
left a comment
There was a problem hiding this comment.
Looks great! just a couple of nits
AsenKimO
requested changes
Oct 12, 2025
Contributor
AsenKimO
left a comment
AsenKimO
left a comment
There was a problem hiding this comment.
Just some minor comments. Otherwise, LGTM 🔥
AsenKimO
approved these changes
Oct 13, 2025
cindy-x-liang
added a commit
that referenced
this pull request
Oct 16, 2025
* Remove codegen build phase * add route filtering * deleted debugging stuff * Added firebase messaging to iOS * addressing richie's comments * Show delay times for start & end, needs double checked with backend * Modified / improved route UI * Reduced redundant code; cleaned up files * Changed location marker image, reorganizec code * Minor comment changes * Addressed Peter's comments * Fixed minor issue * Addressed Richie's comments p1 * Addressed Richie's comments p2 * Addressed Richie's comments p3 * Release (#398) * Remove codegen build phase * add route filtering * deleted debugging stuff * Show delay times for start & end, needs double checked with backend * Added firebase messaging to iOS * addressing richie's comments * Modified / improved route UI * Reduced redundant code; cleaned up files * Changed location marker image, reorganizec code * Minor comment changes * Addressed Peter's comments * Fixed minor issue * Addressed Richie's comments * Release TestFlight 2.0.3 Build 19 (#399) * Remove codegen build phase * add route filtering * deleted debugging stuff * Added firebase messaging to iOS * addressing richie's comments * Show delay times for start & end, needs double checked with backend * Modified / improved route UI * Reduced redundant code; cleaned up files * Changed location marker image, reorganizec code * Minor comment changes * Addressed Peter's comments * Fixed minor issue * Addressed Richie's comments p1 * Addressed Richie's comments p2 * Addressed Richie's comments p3 * Incremented Build and Version --------- Co-authored-by: Vin Bui <vdb23@cornell.edu> Co-authored-by: Vin Bui <75594943+vinnie4k@users.noreply.github.com> Co-authored-by: cindy-x-liang <67083541+cindy-x-liang@users.noreply.github.com> Co-authored-by: Angelina Chen <angelina.chhen@gmail.com> --------- Co-authored-by: Vin Bui <75594943+vinnie4k@users.noreply.github.com> Co-authored-by: Vin Bui <vdb23@cornell.edu> Co-authored-by: cindy-x-liang <67083541+cindy-x-liang@users.noreply.github.com> Co-authored-by: Angelina Chen <angelina.chhen@gmail.com> * Modernized networking architecture with Swift's Combine framework. (#394) * Initial Networking * Finish network refactor * Fix code styling * Merge branch 'master' into Jayson/Networking * update version * Adjust view so Maps icon shows, updated link * Adjust padding * Update Podfile.lock * Change icon and Display name to Navi * Remove alpha channel from AppIcon * correct route versioning * Backup/before rollback (#409) * Initial Networking * Finish network refactor * Fix code styling * Added notifications * Prevent departure notif 10 minute before boarding * temp stash * Change File structure of networking * Change version to 2.1.0 for new notif feature * Fix 10 min calcualtion for notification * update objectversion for cocaopod issue * fixed notifs * merge conflicts * fix errors * addressing peter's comments * remove force unwrap + correct spelling mistake --------- Co-authored-by: Jayson Hahn <46629787+JaysonHahn@users.noreply.github.com> Co-authored-by: Peter <mrpeterssyt@gmail.com> Co-authored-by: AsenKimO <futureguy5760@gmail.com> * rebase --------- Co-authored-by: Vin Bui <vdb23@cornell.edu> Co-authored-by: Vin Bui <75594943+vinnie4k@users.noreply.github.com> Co-authored-by: Angelina Chen <angelina.chhen@gmail.com> Co-authored-by: Richie Sun <105038960+rs929@users.noreply.github.com> Co-authored-by: Jayson Hahn <46629787+JaysonHahn@users.noreply.github.com> Co-authored-by: Angelina Chen <117685487+angelinaa-chen@users.noreply.github.com> Co-authored-by: Jayson Hahn <jhahn8985@gmail.com> Co-authored-by: Peter <mrpeterssyt@gmail.com> Co-authored-by: AsenKimO <futureguy5760@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementing notifs, building off of jayson's