Skip to content

fix(deps): Make storybook as dev dependencies - #437

Merged
ovr merged 3 commits into
mainfrom
fix/deps-story-book
Mar 27, 2024
Merged

fix(deps): Make storybook as dev dependencies#437
ovr merged 3 commits into
mainfrom
fix/deps-story-book

Conversation

@ovr

@ovr ovr commented Mar 26, 2024

Copy link
Copy Markdown
Member

Hello!

I've found that in the Cube repository we install a separate @babel/core.

=> Found "jscodeshift#@babel/core@7.23.9"
info This module exists because "_project_#@cubejs-client#playground#@cube-dev#ui-kit#storybook#@storybook#cli#jscodeshift" depends on it.
=> Found "@storybook/codemod#@babel/core@7.23.9"
info This module exists because "_project_#@cubejs-client#playground#@cube-dev#ui-kit#storybook#@storybook#cli#@storybook#codemod" depends on it.
info Disk size without dependencies: "5.84MB"
info Disk size with unique dependencies: "31.03MB"
info Disk size with transitive dependencies: "54.57MB"

Thanks

@changeset-bot

changeset-bot Bot commented Mar 26, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 26c9352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Mar 26, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 9:39pm

@github-actions

github-actions Bot commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

🏗 Docs are successfully deployed!

👀 Preview: https://660340a45d352f00a8c002a9--cubejs-docs-staging.netlify.app

@github-actions

github-actions Bot commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

🧪 Storybook is successfully deployed!

@github-actions

github-actions Bot commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-29a9504.

@github-actions

Copy link
Copy Markdown
Contributor

🏋️ Size limit report

Name Size Passed?
All 201.62 KB (0% 🟰) Yes 🎉
Tree shaking (just a Button) 27.28 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@ovr
ovr requested a review from tenphi March 27, 2024 08:51
@ovr
ovr merged commit 5411b86 into main Mar 27, 2024
@ovr
ovr deleted the fix/deps-story-book branch March 27, 2024 13:45
@github-actions github-actions Bot mentioned this pull request Mar 27, 2024
ovr added a commit to cube-js/cube that referenced this pull request Mar 27, 2024
It's needed to remove unexpected dependencies from storybook like @babel/core

refs cube-js/cube-ui-kit#437
JichaoS pushed a commit to luabase/cube that referenced this pull request May 7, 2024
It's needed to remove unexpected dependencies from storybook like @babel/core

refs cube-js/cube-ui-kit#437
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
It's needed to remove unexpected dependencies from storybook like @babel/core

refs cube-js/cube-ui-kit#437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants