Skip to content

feat(schema-compiler): Support snake_case aliases for fields - #6396

Merged
ovr merged 5 commits into
masterfrom
schema-pascal-case-aliases
Apr 13, 2023
Merged

feat(schema-compiler): Support snake_case aliases for fields#6396
ovr merged 5 commits into
masterfrom
schema-pascal-case-aliases

Conversation

@ovr

@ovr ovr commented Apr 5, 2023

Copy link
Copy Markdown
Member

Hello!

Thanks

@codecov

codecov Bot commented Apr 5, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 97.05% and project coverage change: +0.04 🎉

Comparison is base (68ba8aa) 47.00% compared to head (d3d53d0) 47.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6396      +/-   ##
==========================================
+ Coverage   47.00%   47.04%   +0.04%     
==========================================
  Files         152      153       +1     
  Lines       20261    20275      +14     
  Branches     5193     5196       +3     
==========================================
+ Hits         9524     9539      +15     
+ Misses       9899     9898       -1     
  Partials      838      838              
Flag Coverage Δ
cube-backend 47.04% <97.05%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bejs-schema-compiler/src/compiler/CubeEvaluator.js 54.12% <ø> (ø)
.../compiler/transpilers/CubePropContextTranspiler.ts 98.63% <ø> (ø)
...kages/cubejs-schema-compiler/src/compiler/utils.ts 96.00% <96.00%> (ø)
...cubejs-schema-compiler/src/compiler/CubeSymbols.js 91.20% <100.00%> (+0.09%) ⬆️
...ubejs-schema-compiler/src/compiler/YamlCompiler.ts 68.70% <100.00%> (-2.55%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr
ovr marked this pull request as ready for review April 5, 2023 17:44
@ovr
ovr requested a review from a team as a code owner April 5, 2023 17:44
@ovr
ovr force-pushed the schema-pascal-case-aliases branch 6 times, most recently from ae9eb8c to 0b71c68 Compare April 12, 2023 09:54
@ovr
ovr force-pushed the schema-pascal-case-aliases branch from ac2b6ed to 2480010 Compare April 13, 2023 13:41
@ovr
ovr merged commit f1b4c0b into master Apr 13, 2023
@ovr
ovr deleted the schema-pascal-case-aliases branch April 13, 2023 14:09
@splatcollision

Copy link
Copy Markdown

I was wondering why some meta object property names in my cube schemas changed all of the sudden, this PR is the culprit. Had to debug front end code for a bit before realizing something had changed in the latest cube code.

I had meta objects in my schemas with snake case property names, a python habit I suppose, but IMO cube shouldn't care about what's in those objects. User expectation is that schema item meta fields should remain unchanged.

https://cube.dev/docs/schema/reference/dimensions#parameters-meta

"Custom metadata. Can be used to pass any information to the frontend."

Cheers and thanks for the great product though!

@ovr

ovr commented Apr 17, 2023

Copy link
Copy Markdown
Member Author

@splatcollision

I am sorry to hear, I've prepared PR with a fix for that - #6444

Good catch 👍

@splatcollision

Copy link
Copy Markdown

OK Thanks, reverting my front-end changes, thanks!

haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants