feat(schema-compiler): Support snake_case aliases for fields - #6396
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6396 +/- ##
==========================================
+ Coverage 47.00% 47.04% +0.04%
==========================================
Files 152 153 +1
Lines 20261 20275 +14
Branches 5193 5196 +3
==========================================
+ Hits 9524 9539 +15
+ Misses 9899 9898 -1
Partials 838 838
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ae9eb8c to
0b71c68
Compare
ac2b6ed to
2480010
Compare
|
I was wondering why some meta object property names in my cube schemas changed all of the sudden, this PR is the culprit. Had to debug front end code for a bit before realizing something had changed in the latest cube code. I had meta objects in my schemas with snake case property names, a python habit I suppose, but IMO cube shouldn't care about what's in those objects. User expectation is that schema item https://cube.dev/docs/schema/reference/dimensions#parameters-meta "Custom metadata. Can be used to pass any information to the frontend." Cheers and thanks for the great product though! |
|
I am sorry to hear, I've prepared PR with a fix for that - #6444 Good catch 👍 |
|
OK Thanks, reverting my front-end changes, thanks! |
Hello!
Thanks