Skip to content

feat(api-gateway, server-core): Renamed Permissions to ApiScopes - #6397

Merged
buntarb merged 2 commits into
masterfrom
feat/permissions_to_api_scope
Apr 12, 2023
Merged

feat(api-gateway, server-core): Renamed Permissions to ApiScopes#6397
buntarb merged 2 commits into
masterfrom
feat/permissions_to_api_scope

Conversation

@buntarb

@buntarb buntarb commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@buntarb
buntarb marked this pull request as ready for review April 5, 2023 20:07
@buntarb
buntarb requested a review from a team as a code owner April 5, 2023 20:07
@codecov

codecov Bot commented Apr 5, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 96.29% and project coverage change: -0.04 ⚠️

Comparison is base (81dddb1) 46.99% compared to head (e93419f) 46.95%.

❗ Current head e93419f differs from pull request most recent head d34492e. Consider uploading reports for the commit d34492e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6397      +/-   ##
==========================================
- Coverage   46.99%   46.95%   -0.04%     
==========================================
  Files         152      152              
  Lines       20250    20249       -1     
  Branches     5188     5188              
==========================================
- Hits         9516     9508       -8     
- Misses       9896     9903       +7     
  Partials      838      838              
Flag Coverage Δ
cube-backend 46.95% <96.29%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-api-gateway/src/interfaces.ts 100.00% <ø> (ø)
packages/cubejs-backend-shared/src/env.ts 64.43% <0.00%> (ø)
...ges/cubejs-server-core/src/core/optionsValidate.ts 100.00% <ø> (ø)
packages/cubejs-server-core/src/core/server.ts 68.99% <ø> (ø)
packages/cubejs-api-gateway/src/gateway.ts 62.75% <100.00%> (+0.23%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buntarb
buntarb force-pushed the feat/permissions_to_api_scope branch from e93419f to d34492e Compare April 12, 2023 14:08
@buntarb
buntarb merged commit 800a96b into master Apr 12, 2023
@buntarb
buntarb deleted the feat/permissions_to_api_scope branch April 12, 2023 14:09
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant