Skip to content

chore(base-driver): Use TLS.ConnectionOptions for SSL configuration - #6411

Merged
ovr merged 1 commit into
masterfrom
base-driver-ssl-options
Apr 13, 2023
Merged

chore(base-driver): Use TLS.ConnectionOptions for SSL configuration#6411
ovr merged 1 commit into
masterfrom
base-driver-ssl-options

Conversation

@ovr

@ovr ovr commented Apr 10, 2023

Copy link
Copy Markdown
Member

Hello!

Thanks

@ovr
ovr force-pushed the base-driver-ssl-options branch from ef32eb3 to ac46b8d Compare April 13, 2023 10:36
@ovr
ovr force-pushed the base-driver-ssl-options branch from ac46b8d to f2ffc44 Compare April 13, 2023 10:36
@codecov

codecov Bot commented Apr 13, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ead63d8) 47.00% compared to head (ac46b8d) 47.00%.

❗ Current head ac46b8d differs from pull request most recent head f2ffc44. Consider uploading reports for the commit f2ffc44 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6411      +/-   ##
==========================================
- Coverage   47.00%   47.00%   -0.01%     
==========================================
  Files         152      152              
  Lines       20260    20261       +1     
  Branches     5193     5193              
==========================================
  Hits         9524     9524              
- Misses       9898     9899       +1     
  Partials      838      838              
Flag Coverage Δ
cube-backend 47.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-base-driver/src/BaseDriver.ts 28.82% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr
ovr marked this pull request as ready for review April 13, 2023 12:55
@ovr
ovr requested a review from a team as a code owner April 13, 2023 12:55
@ovr
ovr merged commit 68ba8aa into master Apr 13, 2023
@ovr
ovr deleted the base-driver-ssl-options branch April 13, 2023 13:22
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant