Skip to content

chore(query-orchestrator): set csvQuery method to protected - #6412

Merged
wolfeeeg merged 1 commit into
masterfrom
orchestrator-exports
Apr 11, 2023
Merged

chore(query-orchestrator): set csvQuery method to protected#6412
wolfeeeg merged 1 commit into
masterfrom
orchestrator-exports

Conversation

@wolfeeeg

Copy link
Copy Markdown
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@github-actions github-actions Bot added the pr:community Contribution from Cube.js community members. label Apr 11, 2023
@wolfeeeg
wolfeeeg requested a review from buntarb April 11, 2023 14:03
@wolfeeeg
wolfeeeg marked this pull request as ready for review April 11, 2023 14:04
@wolfeeeg
wolfeeeg requested a review from a team as a code owner April 11, 2023 14:04
@codecov

codecov Bot commented Apr 11, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (6b1fadb) 46.98% compared to head (fad19ab) 46.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6412   +/-   ##
=======================================
  Coverage   46.98%   46.98%           
=======================================
  Files         152      152           
  Lines       20248    20248           
  Branches     5187     5187           
=======================================
  Hits         9514     9514           
  Misses       9896     9896           
  Partials      838      838           
Flag Coverage Δ
cube-backend 46.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-query-orchestrator/src/orchestrator/QueryCache.ts 72.83% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wolfeeeg
wolfeeeg merged commit 2bc5c8a into master Apr 11, 2023
@wolfeeeg
wolfeeeg deleted the orchestrator-exports branch April 11, 2023 14:24
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants