Skip to content

fix(schema-compiler): Yaml - crash on fully commented file - #6413

Merged
ovr merged 1 commit into
masterfrom
yaml-crash-commented-file
Apr 11, 2023
Merged

fix(schema-compiler): Yaml - crash on fully commented file#6413
ovr merged 1 commit into
masterfrom
yaml-crash-commented-file

Conversation

@ovr

@ovr ovr commented Apr 11, 2023

Copy link
Copy Markdown
Member

Hello!

Thanks

@ovr
ovr requested a review from a team as a code owner April 11, 2023 14:24
@ovr ovr changed the title fix(schema-compiler): Yaml - crash on commented file fix(schema-compiler): Yaml - crash on fully commented file Apr 11, 2023
@codecov

codecov Bot commented Apr 11, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6b1fadb) 46.98% compared to head (9ea45db) 46.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6413   +/-   ##
=======================================
  Coverage   46.98%   46.99%           
=======================================
  Files         152      152           
  Lines       20248    20250    +2     
  Branches     5187     5188    +1     
=======================================
+ Hits         9514     9516    +2     
  Misses       9896     9896           
  Partials      838      838           
Flag Coverage Δ
cube-backend 46.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubejs-schema-compiler/src/compiler/YamlCompiler.ts 71.25% <100.00%> (+0.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr
ovr merged commit 29d2eae into master Apr 11, 2023
@ovr
ovr deleted the yaml-crash-commented-file branch April 11, 2023 15:03
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant