fix(cubestore): RocksStore - migrate table by truncate (unknown tables) - #8053
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
waralexrom
approved these changes
Mar 28, 2024
JichaoS
referenced
this pull request
in luabase/cube
May 7, 2024
…s) (#8053) Iterating without an upper bound leads to reading keys from next table, next index. Downgrading can lead to an unknown TableId on migration. Let's skip these errors by using a range iterator. Debug of fixed version: ``` 2024-03-28 14:22:12,368 TRACE [cubestore::metastore::rocks_store] <pid:50477> Migration for cachestore: started 2024-03-28 14:22:12,369 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating table QueueItems from [3, 1] to [2, 1] 2024-03-28 14:22:12,369 INFO [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from QueueItemRocksTable table row_key Table(QueueItems, 4262) row_key Table(QueueItems, 4263) row_key Table(QueueItems, 4264) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPath index row_key SecondaryIndex(3329, [15, 249, 59, 57, 253, 112, 86, 67], 4264) row_key SecondaryIndex(3329, [61, 0, 52, 15, 64, 107, 132, 62], 4262) row_key SecondaryIndex(3329, [82, 234, 217, 91, 115, 57, 47, 211], 4263) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPath index: done (3 rows) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefixAndStatus index row_key SecondaryIndex(3330, [214, 173, 163, 218, 121, 228, 186, 124], 4262) row_key SecondaryIndex(3330, [214, 173, 163, 218, 121, 228, 186, 124], 4263) row_key SecondaryIndex(3330, [214, 173, 163, 218, 121, 228, 186, 124], 4264) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefixAndStatus index: done (3 rows) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefix index row_key SecondaryIndex(3331, [170, 109, 177, 83, 182, 58, 191, 21], 4262) row_key SecondaryIndex(3331, [170, 109, 177, 83, 182, 58, 191, 21], 4263) row_key SecondaryIndex(3331, [170, 109, 177, 83, 182, 58, 191, 21], 4264) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefix index: done (3 rows) 2024-03-28 14:22:12,370 INFO [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from QueueItemRocksTable table: done (3 rows) 2024-03-28 14:22:12,373 TRACE [cubestore::metastore::rocks_store] <pid:50477> Migration for cachestore: done ```
haechangcho
pushed a commit
to haechangcho/heartcube
that referenced
this pull request
May 15, 2026
…s) (cube-js#8053) Iterating without an upper bound leads to reading keys from next table, next index. Downgrading can lead to an unknown TableId on migration. Let's skip these errors by using a range iterator. Debug of fixed version: ``` 2024-03-28 14:22:12,368 TRACE [cubestore::metastore::rocks_store] <pid:50477> Migration for cachestore: started 2024-03-28 14:22:12,369 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating table QueueItems from [3, 1] to [2, 1] 2024-03-28 14:22:12,369 INFO [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from QueueItemRocksTable table row_key Table(QueueItems, 4262) row_key Table(QueueItems, 4263) row_key Table(QueueItems, 4264) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPath index row_key SecondaryIndex(3329, [15, 249, 59, 57, 253, 112, 86, 67], 4264) row_key SecondaryIndex(3329, [61, 0, 52, 15, 64, 107, 132, 62], 4262) row_key SecondaryIndex(3329, [82, 234, 217, 91, 115, 57, 47, 211], 4263) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPath index: done (3 rows) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefixAndStatus index row_key SecondaryIndex(3330, [214, 173, 163, 218, 121, 228, 186, 124], 4262) row_key SecondaryIndex(3330, [214, 173, 163, 218, 121, 228, 186, 124], 4263) row_key SecondaryIndex(3330, [214, 173, 163, 218, 121, 228, 186, 124], 4264) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefixAndStatus index: done (3 rows) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefix index row_key SecondaryIndex(3331, [170, 109, 177, 83, 182, 58, 191, 21], 4262) row_key SecondaryIndex(3331, [170, 109, 177, 83, 182, 58, 191, 21], 4263) row_key SecondaryIndex(3331, [170, 109, 177, 83, 182, 58, 191, 21], 4264) 2024-03-28 14:22:12,370 TRACE [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from ByPrefix index: done (3 rows) 2024-03-28 14:22:12,370 INFO [cubestore::metastore::rocks_table] <pid:50477> Migrating by truncating rows from QueueItemRocksTable table: done (3 rows) 2024-03-28 14:22:12,373 TRACE [cubestore::metastore::rocks_store] <pid:50477> Migration for cachestore: done ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Iterating without an upper bound leads to reading keys from next table, next index. Downgrading can lead to an unknown tableId on migration. Let's skip these errors by using a range iterator.
Debug of fixed version:
Thanks