Skip to content

feat: Ungrouped query pre-aggregation support - #8058

Merged
paveltiunov merged 1 commit into
masterfrom
ungrouped-pre-agg-support
Mar 29, 2024
Merged

feat: Ungrouped query pre-aggregation support#8058
paveltiunov merged 1 commit into
masterfrom
ungrouped-pre-agg-support

Conversation

@paveltiunov

@paveltiunov paveltiunov commented Mar 29, 2024

Copy link
Copy Markdown
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov
paveltiunov requested review from a team as code owners March 29, 2024 05:11
@vercel

vercel Bot commented Mar 29, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am
examples-react-d3 ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am
examples-react-dashboard ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am
examples-react-data-table ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am
examples-react-material-ui ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am
examples-react-pivot-table ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am
examples-vue-query-builder ⬜️ Ignored (Inspect) Mar 29, 2024 5:11am

@codecov

codecov Bot commented Mar 29, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 36.36364% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 47.90%. Comparing base (19f6245) to head (69904fd).

Files Patch % Lines
...ejs-schema-compiler/src/adapter/PreAggregations.js 33.33% 10 Missing and 2 partials ⚠️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8058       +/-   ##
===========================================
- Coverage   61.92%   47.90%   -14.02%     
===========================================
  Files         351      154      -197     
  Lines       48637    21034    -27603     
  Branches     5415     5422        +7     
===========================================
- Hits        30119    10077    -20042     
+ Misses      17766    10203     -7563     
- Partials      752      754        +2     
Flag Coverage Δ
cube-backend 47.90% <36.36%> (-0.03%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov
paveltiunov merged commit 2ca99de into master Mar 29, 2024
@paveltiunov
paveltiunov deleted the ungrouped-pre-agg-support branch March 29, 2024 05:48
haechangcho pushed a commit to haechangcho/heartcube that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant