event-protocol: Add ruby formatter#173
event-protocol: Add ruby formatter#173mattwynne merged 2 commits intoevent-protocol-test-resultsfrom
Conversation
43b7ff3 to
afa562d
Compare
afa562d to
88bab92
Compare
|
@aslakhellesoy the build is broken as there's no Makefile in the |
|
Yes please do. Each |
1ae9fe0 to
cea607c
Compare
aslakhellesoy
left a comment
There was a problem hiding this comment.
Looks good to me, after fixing those two comments I made. If the Travis build passes, go ahead and merge it!
event-protocol/ruby/Gemfile
Outdated
| source 'https://rubygems.org' | ||
| gemspec | ||
|
|
||
| gem "cucumber", path: "../../../cucumber-ruby" |
There was a problem hiding this comment.
This might work on your machine, but it breaks the build.
I suggest depending on the git repo (with a particular branch) instead.
There was a problem hiding this comment.
Oh yeah I should have taken that out. Thanks!
event-protocol/ruby/LICENSE.txt
Outdated
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2017 Cucumber Limited and contributors | |||
There was a problem hiding this comment.
Never add year to Copyright. It's not required and nobody remembers to update it.
cea607c to
598f861
Compare
This prepares the way for keeping protocol formatters / emitters together in the event-protocol folder too.
598f861 to
c4ccfef
Compare
a6df1ea to
5606d2e
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Add a plugin for cucumber-ruby that produces events according to the protocol defined in #172
Details
This plugin emits the necessary NDJSON events for driving the prototype GUI (see #171) and satisfies the protocol defined in #172.
Motivation and Context
This provides the first version of a producer of the new test-result events proposed in #172. It can act as a reference implementation for other Cucumbers to follow when implementing their own.
Keeping the plugin here in the monorepo rather than in the cucumber-ruby codebase will enable other implementors to re-use tests (or perhaps we can even see how to develop a shared test suite).
Once this gem has been published, we'll use it as a dependency in Cucumber-Ruby 3.0, and make it one of the standard command-line options.
How Has This Been Tested?
The set of examples in
/event-protocol/ruby/exampleseach contain anexpected-events.ndjson. The RSpec tests for the project run Cucumber (with the plugin enabled) for each of the examples, and compare the output from the plugin with that file.Because of some non-deterministic data in the events, the data is somewhat normalised before comparison. Read the code for details.
Types of changes
Checklist: