Refactor populateDist#1380
Merged
Merged
Conversation
pokey
force-pushed
the
pokey/refactor-populatedist
branch
2 times, most recently
from
38d9a5b to
bb58a72
Compare
pokey
commented
Apr 3, 2023
| @@ -0,0 +1,3 @@ | |||
| import { run } from "./populateDist"; | |||
|
|
|||
| run(); | |||
Member
Author
There was a problem hiding this comment.
wasn't quite sure what the convention is for a script that kinda spans a bunch of files. Decided to just have the index.ts be the entrypoint of the script and not export anything
pokey
force-pushed
the
pokey/refactor-populatedist
branch
from
bb58a72 to
88bd923
Compare
5 tasks
pokey
force-pushed
the
pokey/refactor-populatedist
branch
3 times, most recently
from
8453c18 to
2e5d2f5
Compare
pokey
force-pushed
the
pokey/refactor-populatedist
branch
from
2e5d2f5 to
2b7cc22
Compare
AndreasArvidsson
approved these changes
Apr 6, 2023
pokey
added a commit
that referenced
this pull request
Apr 12, 2023
- Depends on #1380 - Depends on #1378 - Depends on #1412 (due to use of new typescript `satisfies` operator not supported by older versions of `prettier`) ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet - [x] ~~Maybe better to rebase onto #1393?~~ should be easy to merge these changes with that so let's not bother - [x] ~~Add test for real font measurements~~ Filed follow-up #1420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour should be identical; just splits
populateDistinto multiple filesChecklist