Skip to content

Run pnpm dedupe#1746

Merged
pokey merged 1 commit into
mainfrom
pnpm-dedupe-20230808
Aug 9, 2023
Merged

Run pnpm dedupe#1746
pokey merged 1 commit into
mainfrom
pnpm-dedupe-20230808

Conversation

@auscompgeek
Copy link
Copy Markdown
Member

@auscompgeek auscompgeek commented Aug 8, 2023

#1745 is almost impossible to review 😅

I'd suggest running pnpm dedupe on the PR but it turns out main has a whole bunch of duplicate transitive deps too, so running it against main first.

Checklist

@auscompgeek auscompgeek requested a review from pokey as a code owner August 8, 2023 11:48
@pokey
Copy link
Copy Markdown
Member

pokey commented Aug 8, 2023

I thought pnpm deduped by default nowadays?

@pokey pokey enabled auto-merge August 8, 2023 11:51
Comment thread pnpm-lock.yaml
Comment thread pnpm-lock.yaml
@auscompgeek
Copy link
Copy Markdown
Member Author

I thought pnpm deduped by default nowadays?

🤷 I don't think it'll try to update existing locked transitive dependencies, but will reuse existing resolutions. Both pnpm and yarn behave this way I think.

@pokey pokey disabled auto-merge August 8, 2023 12:09
@pokey pokey mentioned this pull request Aug 8, 2023
@pokey pokey added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit 851e0bc Aug 9, 2023
@pokey pokey deleted the pnpm-dedupe-20230808 branch August 9, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants