Stop publishing API docs#1750
Merged
Merged
Conversation
pokey
commented
Aug 8, 2023
Member
Author
There was a problem hiding this comment.
Moved this into its own file to make it easier to link to
auscompgeek
reviewed
Aug 8, 2023
AndreasArvidsson
approved these changes
Aug 8, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
We have some security warnings on a couple packages that are dependencies of docusaurus, so I decided to upgrade to the latest to remove those dependencies. Docusaurus uses their nightly version on their own docs, and things seem to work for us on this version with no issue, so I think it's ok. In addition, we were violating their peer dependencies by using react 18; we now no longer need to do that. Also, this version allows us to use mdx v2, which has a lot of niceties that we'll probably want as we do our big docs refactor (#867) - depends on #1750 to fix typedoc failure ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm removeon all our typedoc dependencies once Bump docusaurus to3.0.0-alpha.0#1745 is merged so we don't get massive merge conflicts on ourpnpm.lock😅Checklist