Migrate Python branch scopes to fixtures#2389
Merged
AndreasArvidsson merged 3 commits intoJun 5, 2024
Merged
Conversation
Member
Author
|
Nice to see the reduction in lines of code here 🙌 |
Member
AndreasArvidsson
left a comment
AndreasArvidsson
left a comment
There was a problem hiding this comment.
Nice. First actual use of the scope recorder!
Easy to use? No problems?
AndreasArvidsson
approved these changes
Jun 5, 2024
Member
Definitely! Really happy with this new format. |
Member
Author
|
Actually forgot to remove the "chuck" tests. Now that's a pretty impressive reduction in loc |
Member
Author
|
And looks like I missed a couple branch tests. Now all Python branch tests have been migrated. Have one more quick look when you get a minute and merge if you're happy |
AndreasArvidsson
approved these changes
Jun 5, 2024
AndreasArvidsson
deleted the
pokey/migrate-python-branch-scopes-to-fixtures
branch
Member
Author
Yep! Made a few tweaks as you saw, but otherwise quite usable. Definitely seems like a win |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured while I was testing #2383 I might as well do something useful at the same time 😊
Checklist