Skip to content

Harden deploy workflow_run trust checks #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phillco wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Harden deploy workflow_run trust checks #3276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
publish-vscode-extension:
name: Publish VSCode extension
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
if: ${{ github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'push' && github.event.workflow_run.head_repository.full_name == github.repository }}
environment: production
env:
CURSORLESS_REPO_ROOT: ${{ github.workspace }}
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
publish-neovim-extension:
name: Publish Neovim extension
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
if: ${{ github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'push' && github.event.workflow_run.head_repository.full_name == github.repository }}
environment: production
env:
CURSORLESS_REPO_ROOT: ${{ github.workspace }}
Expand Down Expand Up @@ -99,6 +99,7 @@ jobs:
push-cursorless-talon:
name: Push cursorless-talon subrepo
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'push' && github.event.workflow_run.head_repository.full_name == github.repository }}
needs: publish-vscode-extension
environment: production
env:
Expand Down
Loading