chore: update vite to version 5 inside the monorepo by AtofStryker · Pull Request #29617 · cypress-io/cypress

AtofStryker · 2024-06-05T01:04:48Z

Additional details

updates the monorepo from vite 4 to vite 5. additionally updates babel and vite related dependencies.

Steps to test

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

cypress · 2024-06-05T01:41:44Z

Passing run #55778 ↗︎

0	232	4	0	0

Details:

Merge branch 'develop' into chore/update_monorepo_to_vite_5
Project: cypress	Commit: `1672dffcea`
Status: Passed	Duration: 11:36 💡
Started: Jun 12, 2024 8:36 PM	Ended: Jun 12, 2024 8:48 PM

Review all test suite changes for PR #29617 ↗︎

…5, vite related vue plugins to version 5, and svg plugin to v5 update vitejs react to v5 updated vite plugins updates unplugin-vue-components and unplugin-icons for vite remove vite-plugin-copmponents as it is the same thing as unplugin-vue-components update vue-i18n from beta package to released v9 get unplugin-vue-i18n to latest add @babel/types to no rewrite [run ci] fix typing errors [run ci]

AtofStryker · 2024-06-06T03:53:14Z

packages/app/cypress/e2e/top-nav.cy.ts

      it('shows the current browser in the top nav browser list button', () => {
        cy.findByTestId('top-nav-active-browser-icon')
        .should('have.attr', 'src')
-        .and('contain', 'chrome')


no longer applicable since the src doesn't contain chrome when transformed by updated vite-svg-loader

Why was it checking for chrome previously? Is there something else we should be checking for instead?

because chrome in this case is the active browser. the src no longer contains chrome so we can't assert on it, but the below assertion I feel should be enough

AtofStryker · 2024-06-06T03:55:05Z

packages/frontend-shared/src/locales/i18n.ts

 export function createI18n (opts = {}) {
  return _createI18n<MessageSchema, 'en-US'>({
    locale: 'en-US',
+    // @ts-expect-error


has to do with the key for the message value pair can be any string, where as the type is expecting en-us

oof, this is a huge shortcoming of that library when it comes to typescript... how about we coerce the type instead? e.g.

/** * precompiled messages from unplugin-vue-i18n do not include explicit keys derived from * the filenames of the raw message sources, so it must be coerced. */ messages: compiledMessages as { 'en-US': MessageSchema },

AtofStryker · 2024-06-06T03:57:25Z

npm/webpack-preprocessor/__snapshots__/compilation.spec.js

-[0m[31m[1m>[22m[39m[90m 1 |[39m describe([32m'fail'[39m[33m,[39m [33m-[39m[33m>[39m)[0m
-[0m [90m   |[39m                   [31m[1m^[22m[39m[0m
-[0m [90m 2 |[39m[0m
+[0m[31m[1m>[22m[39m[90m 1 |[39m describe([32m'fail'[39m[33m,[39m [33m-[39m[33m>[39m)


needed to update the snapshot. Likely due to the babel code frame updates

AtofStryker · 2024-06-06T04:10:26Z

percy changes look as expected. There is one snapshot that is showing double chevrons, but when I run the test locally I only see the 1 chevron as expected so I am not sure what is happening there.

AtofStryker · 2024-06-06T11:55:21Z

system-tests/__snapshots__/record_spec.js

                'relativeFile': 'cypress/e2e/record_uncaught.cy.js',
                'absoluteFile': '/foo/bar/.projects/e2e/cypress/e2e/record_uncaught.cy.js',
-                'frame': '> 1 | throw new Error(\'instantly fails\')\n    |       ^\n  2 | ',
+                'frame': '> 1 | throw new Error(\'instantly fails\')\n    |       ^\n  2 |',


snapshot update likely due to the babel code frame updates (change was a space).

ryanthemanuel · 2024-06-06T14:37:04Z

yarn.lock


-"@babel/core@7.23.2", "@babel/core@^7.0.0", "@babel/core@^7.17.9", "@babel/core@^7.18.9", "@babel/core@^7.20.7", "@babel/core@^7.21.3", "@babel/core@^7.21.4", "@babel/core@^7.22.9":
+"@babel/core@7.23.2":


We used to resolve down to one version of @babel/core and now there are 3. Do we know why?

I'm not entirely sure, but I did install some of these in different commits and then squashed it down. I am wondering if it has to do with @vitejs/plugin-react@4.3.0 or some of the other packages needed a newer version of core, but I would think this could be deduped if needed? Not sure the easiest way to do that.

cacieprins · 2024-06-07T19:49:52Z

packages/frontend-shared/src/locales/i18n.ts

 export function createI18n (opts = {}) {
  return _createI18n<MessageSchema, 'en-US'>({
    locale: 'en-US',
+    // @ts-expect-error


oof, this is a huge shortcoming of that library when it comes to typescript... how about we coerce the type instead? e.g.

/** * precompiled messages from unplugin-vue-i18n do not include explicit keys derived from * the filenames of the raw message sources, so it must be coerced. */ messages: compiledMessages as { 'en-US': MessageSchema },

…n unplugin-vue-i18n and vue-i18n [run ci]

AtofStryker · 2024-06-07T20:11:01Z

@cacieprins done in 8621571.

#29634) * fix vite * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>

jennifer-shehane · 2024-06-11T14:01:05Z

@AtofStryker There are some conflicts with the v8 snapshots

AtofStryker · 2024-06-11T14:49:43Z

@jennifer-shehane kicked off the job to update them. Then in conflicts are still present I will elect to take the changes on this branch

jennifer-shehane · 2024-06-12T13:59:52Z

@AtofStryker Still conflicts

AtofStryker · 2024-06-12T14:20:44Z

@AtofStryker Still conflicts

in this case its just the hash so thats good!. I'll push up in a few with the conflicts resolved

…date_monorepo_to_vite_5

jennifer-shehane · 2024-06-12T15:20:41Z

@AtofStryker Sorry 😅 more conflicts.

cypress-bot · 2024-06-18T22:22:36Z

Released in 13.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.12.0, please open a new issue.

AtofStryker force-pushed the chore/update_monorepo_to_vite_5 branch from 9f064c0 to c3f4c77 Compare June 5, 2024 18:38

AtofStryker changed the title ~~update vite to version 5 inside the monorepo~~ chore: update vite to version 5 inside the monorepo Jun 5, 2024

AtofStryker force-pushed the chore/update_monorepo_to_vite_5 branch from c3f4c77 to c3a0918 Compare June 5, 2024 20:49

AtofStryker commented Jun 6, 2024

View reviewed changes

update snapshot [run ci]

8d0ee9c

AtofStryker commented Jun 6, 2024

View reviewed changes

AtofStryker marked this pull request as ready for review June 6, 2024 12:03

AtofStryker requested review from cacieprins, mschile and ryanthemanuel and removed request for cacieprins June 6, 2024 12:04

ryanthemanuel reviewed Jun 6, 2024

View reviewed changes

AtofStryker requested a review from ryanthemanuel June 7, 2024 19:10

cacieprins requested changes Jun 7, 2024

View reviewed changes

coerce type for compiled messages to bridge type compatibility betwee…

8621571

…n unplugin-vue-i18n and vue-i18n [run ci]

AtofStryker requested a review from cacieprins June 7, 2024 20:11

ryanthemanuel and others added 3 commits June 7, 2024 19:45

update other hard coded @babel/core

3efee42

Merge branch 'develop' into chore/update_monorepo_to_vite_5

adeb1b3

ryanthemanuel approved these changes Jun 11, 2024

View reviewed changes

cypress-bot[bot] added 2 commits June 11, 2024 16:03

chore: updating v8 snapshot cache

911f7cd

chore: updating v8 snapshot cache

1e78cec

cacieprins approved these changes Jun 11, 2024

View reviewed changes

Merge branch 'develop' of github.com:cypress-io/cypress into chore/up…

f678117

…date_monorepo_to_vite_5

jennifer-shehane assigned AtofStryker Jun 12, 2024

Merge branch 'develop' into chore/update_monorepo_to_vite_5

1672dff

AtofStryker merged commit ee3ff88 into develop Jun 12, 2024

AtofStryker deleted the chore/update_monorepo_to_vite_5 branch June 12, 2024 20:51

MikeMcC399 mentioned this pull request Jun 18, 2024

TypeScript errors - building Cypress from source - 13.3.1 regression #28049

Closed

cypress-bot bot locked as resolved and limited conversation to collaborators Jun 18, 2024


		"@babel/core@7.23.2", "@babel/core@^7.0.0", "@babel/core@^7.17.9", "@babel/core@^7.18.9", "@babel/core@^7.20.7", "@babel/core@^7.21.3", "@babel/core@^7.21.4", "@babel/core@^7.22.9":
		"@babel/core@7.23.2":

Conversation

AtofStryker commented Jun 5, 2024 • edited by jennifer-shehane Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Uh oh!

cypress bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Passing run #55778 ↗︎

Review all test suite changes for PR #29617 ↗︎

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AtofStryker Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AtofStryker commented Jun 6, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AtofStryker commented Jun 7, 2024

Uh oh!

jennifer-shehane commented Jun 11, 2024

Uh oh!

AtofStryker commented Jun 11, 2024

Uh oh!

jennifer-shehane commented Jun 12, 2024

Uh oh!

AtofStryker commented Jun 12, 2024

Uh oh!

jennifer-shehane commented Jun 12, 2024

Uh oh!

cypress-bot bot commented Jun 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AtofStryker commented Jun 5, 2024 •

edited by jennifer-shehane

Loading

cypress bot commented Jun 5, 2024 •

edited

Loading

AtofStryker Jun 6, 2024 •

edited

Loading