Merged
Conversation
mbostock
force-pushed
the
mbostock/path-round
branch
from
9d96fa4 to
4684531
Compare
Member
|
yummy! |
Member
Author
|
Did you mean to approve along with the “yummy” comment? 😁 |
Member
|
more like pre-approval —I don't want us to merge this since we depend on the upstream release, and still have to write docs |
Member
Author
|
I was waiting to merge and release the d3-path stuff until I was sure that the downstream PRs like this one would be acceptable. So we are deadlocked. But if you approve of this one then I will start the release process for d3-path and d3-geo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. d3/d3-path#12