Skip to content

feat: allow optional options to be passed to @dadi/logger#386

Merged
adamkdean merged 4 commits into2.2.xfrom
feature/2.2.x-logger-options
Feb 20, 2018
Merged

feat: allow optional options to be passed to @dadi/logger#386
adamkdean merged 4 commits into2.2.xfrom
feature/2.2.x-logger-options

Conversation

@adamkdean
Copy link
Copy Markdown
Contributor

This PR allows options to be passed to the instance of @dadi/logger, and works hand-in-hand with dadi/logger#53.

@adamkdean adamkdean self-assigned this Feb 16, 2018
@adamkdean adamkdean requested a review from jimlambie February 16, 2018 16:33
@adamkdean
Copy link
Copy Markdown
Contributor Author

☹️

  166 passing (2m)
  7 pending
  1 failing
  1) logger request "before each" hook: resetLog for "should log to the access log when collection endpoint is requested":
     Error: ENOENT: no such file or directory, open './log/dadi-api.access.log'

@jimlambie
Copy link
Copy Markdown
Contributor

@adamkdean I can look at the tests if you want?

Copy link
Copy Markdown
Contributor

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamkdean
Copy link
Copy Markdown
Contributor Author

@jimlambie that'd be great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants