Experimental api stuff#24
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces experimental API functionality for daggerml by refactoring existing code and adding new features. The changes move implementation details to a new internal module and enhance the public API interface.
Key changes:
- Refactored experimental API implementation into a new
_api.pymodule - Added comprehensive test coverage for the new experimental API functionality
- Enhanced error handling and validation in the API implementation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/unit/experimental/test_api.py |
Updated imports and moved tests to support new module structure |
tests/integration/test_funkifys.py |
Removed unused parameter from test function |
tests/integration/test_experimental_api.py |
Added extensive integration tests for experimental API features |
tests/conftest.py |
Added new fake_dml fixture for mocking DML components |
src/dml_util/funk.py |
Improved error handling by replacing assertion with proper exception |
src/dml_util/experimental/api.py |
Refactored to expose only public interface from internal module |
src/dml_util/experimental/_api.py |
New implementation module with enhanced functionality |
README.md |
Added comprehensive documentation for the experimental API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.