Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the DaggerML codebase to move away from a dot operator-centered approach to a more method-based design. The changes simplify the API by replacing implicit property assignments with explicit method calls while maintaining similar functionality.
- Replaces
ResourcewithExecutablefor function resources - Changes from property-based DAG operations (
d0.result = value) to explicit method calls (d0.commit(value)) - Renames internal methods and removes complex attribute handling in favor of simpler method-based operations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_core.py | Updates test cases to use new method-based API and replaces Resource with Executable |
| tests/assets/fns/sum.py | Updates function implementation to use new DAG method calls |
| tests/assets/fns/async.py | Updates async function to use commit method instead of result property |
| submodules/daggerml_cli | Updates submodule reference to newer commit |
| src/daggerml/core.py | Major refactoring of core classes to implement method-based API design |
| src/daggerml/init.py | Adds Executable to public API exports |
Comments suppressed due to low confidence (1)
src/daggerml/core.py:1
- The method references
self.nodeswhich is not defined anywhere in theDagclass. This will cause anAttributeErrorwhen the method is called.
import json
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.