Skip to content

Move back to methods (from everything being centered around the dot operator).#22

Merged
amniskin merged 8 commits into
masterfrom
cleanup
Sep 10, 2025
Merged

Move back to methods (from everything being centered around the dot operator).#22
amniskin merged 8 commits into
masterfrom
cleanup

Conversation

@amniskin
Copy link
Copy Markdown
Contributor

@amniskin amniskin commented Sep 4, 2025

No description provided.

@amniskin amniskin requested a review from Copilot September 4, 2025 06:11

This comment was marked as outdated.

@amniskin amniskin requested a review from Copilot September 10, 2025 03:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the DaggerML codebase to move away from a dot operator-centered approach to a more method-based design. The changes simplify the API by replacing implicit property assignments with explicit method calls while maintaining similar functionality.

  • Replaces Resource with Executable for function resources
  • Changes from property-based DAG operations (d0.result = value) to explicit method calls (d0.commit(value))
  • Renames internal methods and removes complex attribute handling in favor of simpler method-based operations

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_core.py Updates test cases to use new method-based API and replaces Resource with Executable
tests/assets/fns/sum.py Updates function implementation to use new DAG method calls
tests/assets/fns/async.py Updates async function to use commit method instead of result property
submodules/daggerml_cli Updates submodule reference to newer commit
src/daggerml/core.py Major refactoring of core classes to implement method-based API design
src/daggerml/init.py Adds Executable to public API exports
Comments suppressed due to low confidence (1)

src/daggerml/core.py:1

  • The method references self.nodes which is not defined anywhere in the Dag class. This will cause an AttributeError when the method is called.
import json

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/test_core.py Outdated
amniskin and others added 2 commits September 9, 2025 20:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@amniskin amniskin merged commit c2dd1e5 into master Sep 10, 2025
14 checks passed
@amniskin amniskin deleted the cleanup branch September 10, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants