Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for keyword arguments (kwargs) to function calls in DaggerML, allowing functions to override prepopulated values dynamically at call time. The changes enable more flexible function execution by supporting kwargs that can override existing prepop values in Executable objects.
- Support for kwargs in
dag.call()andExecutableNode.__call__()methods - Validation to ensure kwargs correspond to existing prepop keys
- Consolidation of test fixtures to use a shared
dmlfixture
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/daggerml/core.py | Adds kwargs support to call methods and improves node documentation handling |
| tests/test_core.py | Refactors tests to use shared dml fixture and adds kwargs validation tests |
| tests/conftest.py | Introduces pytest fixtures for DML testing infrastructure |
| CONTRIBUTING.md | Adds documentation for pytest markers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # FIXME: replace fails: `TypeError: Executable.__init__() missing 1 required positional argument: 'uri'` | ||
| # fn = replace(fn, prepop={**fn.prepop, **kw}) |
There was a problem hiding this comment.
The commented FIXME indicates incomplete implementation. Consider either implementing the replace functionality properly or removing the comment if the current approach is intentional.
| # FIXME: replace fails: `TypeError: Executable.__init__() missing 1 required positional argument: 'uri'` | |
| # fn = replace(fn, prepop={**fn.prepop, **kw}) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.