Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
dschafer
added a commit
to dschafer/dagster
that referenced
this pull request
Jul 9, 2025
I ran into issues when my venv python version was 3.12.1 the other day. Digging in, it looks like the `type_params` parameter to `ForwardRef._evaluate` was only added in 3.12.4, but after dagster-io#28960 we're using it in 3.12.(<4) (@alangenfeld ran into something similar in dagster-io#22986, it looks like). This moves the non-`type_params` branch to `< (3, 12, 4)`, and keeps the `type_params` branch in the else. == Test Plan Make a venv for 3.12.1, build, and run: ```sh uv venv --python 3.12.1 source .venv/bin/activate make dev_install dagster --version ``` Before, the following error would occur: ``` TypeError: ForwardRef._evaluate() got an unexpected keyword argument 'type_params' ``` After, you correctly see "dagster, version 1!0+dev"
alangenfeld
pushed a commit
that referenced
this pull request
Jul 9, 2025
## Summary & Motivation I ran into issues when my venv python version was 3.12.1 the other day. Digging in, it looks like the `type_params` parameter to `ForwardRef._evaluate` was only added in 3.12.4, but after #28960 we're using it in 3.12.(<4) (@alangenfeld ran into something similar in #22986, it looks like). This moves the non-`type_params` branch to `< (3, 12, 4)`, and keeps the `type_params` branch in the else. ## How I Tested These Changes Make a venv for 3.12.1, build, and run: ```sh uv venv --python 3.12.1 source .venv/bin/activate make dev_install dagster --version ``` Before, the following error would occur: ``` TypeError: ForwardRef._evaluate() got an unexpected keyword argument 'type_params' ``` After, you correctly see "dagster, version 1!0+dev"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recursive_guardgot made keyword arg only in python/cpython#118009 which released in3.12.4(we run an older version in buildkite so we missed it)fixes #22985
How I Tested These Changes
on a fresh 3.12.4 venv
pytest python_modules/dagster/dagster_tests/general_tests/test_record.py python_modules/dagster/dagster_tests/general_tests/check_tests/test_check.pywhich was failing before fix