Add options to spark_df_output_schema#2616
Merged
schrockn merged 6 commits intodagster-io:masterfrom Jun 23, 2020
Merged
Conversation
Update forked repository.
Update forked repository.
schrockn
requested changes
Jun 17, 2020
Member
schrockn
left a comment
schrockn
left a comment
There was a problem hiding this comment.
Awesome! Thanks a bunch for this
python_modules/libraries/dagster-pyspark/dagster_pyspark/types.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-pyspark/dagster_pyspark/types.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-pyspark/dagster_pyspark/types.py
Outdated
Show resolved
Hide resolved
Member
|
Some tests would be good too... |
schrockn
approved these changes
Jun 22, 2020
Member
schrockn
left a comment
schrockn
left a comment
There was a problem hiding this comment.
looks good. would be awesome to have final, minor comments addressed. thanks so much!
python_modules/libraries/dagster-pyspark/dagster_pyspark/types.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_typenow supports the following types ['csv', 'jdbc', 'json', 'orc', 'parquet', 'saveAsTable', 'text'].file_optionsnow supports all existing params.